Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxy): handle consumed responses #321

Merged
merged 1 commit into from
Feb 8, 2023
Merged

fix(proxy): handle consumed responses #321

merged 1 commit into from
Feb 8, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Feb 8, 2023

In node, when new response is manually constructed (unenv) _data is set and it will be consumed. This PR handles this situation using internal API.

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #321 (340b0e7) into main (4d1459c) will decrease coverage by 0.13%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
- Coverage   66.74%   66.62%   -0.13%     
==========================================
  Files          24       24              
  Lines        2481     2481              
  Branches      289      290       +1     
==========================================
- Hits         1656     1653       -3     
- Misses        825      828       +3     
Impacted Files Coverage Δ
src/utils/proxy.ts 85.18% <45.45%> (-2.78%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit ba2ca46 into main Feb 8, 2023
@pi0 pi0 deleted the feat/proxy-path branch February 8, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant