Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clearSession): accept partial session config #328

Merged
merged 2 commits into from
Feb 20, 2023
Merged

fix(clearSession): accept partial session config #328

merged 2 commits into from
Feb 20, 2023

Conversation

zhiyuanzmj
Copy link
Contributor

@zhiyuanzmj zhiyuanzmj commented Feb 14, 2023 •
edited 

// before need `password`
await clearSession(event, {password: '...'})

//  after
await clearSession(event)

pi0
pi0 reviewed Feb 16, 2023
View reviewed changes
src/utils/session.ts Outdated Show resolved Hide resolved
zhiyuanzmj
zhiyuanzmj commented Feb 18, 2023
View reviewed changes
Copy link
Contributor Author

@zhiyuanzmj zhiyuanzmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feat(clearSession): password optional

src/utils/session.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title refactor(clearSession): set the config parameter optional fix(clearSession): accept partial session config Feb 20, 2023
pi0
pi0 approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 80f2c61 into unjs:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhiyuanzmj @pi0