fix: sanitize utils and sanitize all response code and messages #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
reviewed
Mar 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #358 +/- ##
==========================================
- Coverage 74.60% 74.57% -0.04%
==========================================
Files 25 26 +1
Lines 2359 2407 +48
Branches 370 380 +10
==========================================
+ Hits 1760 1795 +35
- Misses 599 612 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
danielroe
reviewed
Mar 15, 2023
danielroe
changed the title
danielroe
reviewed
Mar 15, 2023
Co-authored-by: Daniel Roe <daniel@roe.dev>
danielroe
reviewed
Mar 15, 2023
Co-authored-by: Daniel Roe <daniel@roe.dev>
danielroe
reviewed
Mar 15, 2023
Comment on lines
+101
to
+108
| // TODO: Always sanitize status message in the next major releases | ||
| const originalMessage = err.statusMessage; | ||
| const sanitizedMessage = sanitizeStatusMessage(err.statusMessage); | ||
| if (sanitizedMessage !== originalMessage) { | ||
| console.warn( | ||
| "[h3] Please prefer using `message` for longer error messages instead of `statusMessage`. In the future `statusMessage` will be sanitized by default." | ||
| ); | ||
| } |
danielroe
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #357, this PR fixes all setters of
statusCodeandstatusMessagewith two newsanetizeStatusCodeandsanetizeStatusMessageutils