fix(proxy): split cookie headers properly with native node fetch #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #408 +/- ##
==========================================
+ Coverage 76.08% 76.15% +0.06%
==========================================
Files 26 26
Lines 2438 2445 +7
Branches 338 339 +1
==========================================
+ Hits 1855 1862 +7
Misses 583 583
|
pi0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxy on Node.js >= 18, uses native
fetch(which already splitsset-cookieheaders). Because of this, we need to merge/split all cookie headers and set it once otherwise (currently) only first cookie(s) will be added.