Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support event.handled flag #410

Merged
merged 1 commit into from
Jun 20, 2023
Merged

feat: support event.handled flag #410

merged 1 commit into from
Jun 20, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jun 20, 2023

Currently, we were directly depending on node writableEnded flag to determine if a response is ended or not. Sometimes user wants to takeover. By introducing more standard event.handled flag we can support it (first step will be possible with internal/experimental _handled flag when needed)

@pi0 pi0 merged commit 5b9a2f0 into main Jun 20, 2023
3 checks passed
@pi0 pi0 deleted the feat/event-handle branch June 20, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant