Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache, proxy, response): avoid sending handled events #411

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jun 20, 2023

When event is handled, utils should early return and avoid calling node.res.end

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #411 (4dceb6f) into main (5b9a2f0) will decrease coverage by 1.99%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   76.65%   74.66%   -1.99%     
==========================================
  Files          26       26              
  Lines        2480     2491      +11     
  Branches      355      353       -2     
==========================================
- Hits         1901     1860      -41     
- Misses        579      631      +52     
Impacted Files Coverage Δ
src/utils/cache.ts 27.77% <0.00%> (-1.07%) ⬇️
src/utils/response.ts 62.61% <50.00%> (-0.24%) ⬇️
src/utils/proxy.ts 83.33% <60.00%> (-0.59%) ⬇️

... and 3 files with indirect coverage changes

@pi0 pi0 merged commit 23b3f6b into main Jun 20, 2023
3 of 5 checks passed
@pi0 pi0 deleted the fix/guard-end branch June 20, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant