Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve H3Error #415

Merged
merged 4 commits into from
Jun 26, 2023
Merged

refactor: improve H3Error #415

merged 4 commits into from
Jun 26, 2023

Conversation

tal7aouy
Copy link
Contributor

Here are the changes I made to improve H3Error

  • Added JSDoc comments for better code documentation.

  • Fixed the incorrect property types in the class definition of H3Error.

  • Fixed the incorrect property assignment in the constructor of H3Error.

  • Added explicit return types for functions.

  • Improved code formatting and consistency.

  • Fixed a typo in the comment for the sendError function.

@pi0 pi0 changed the title improved H3Error refactor: improve H3Error Jun 26, 2023
src/error.ts Show resolved Hide resolved
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯

@pi0 pi0 merged commit 0a4ba0b into unjs:main Jun 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants