Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sendNoContent): preserve custom status code if already set #577

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

wolodev
Copy link
Contributor

@wolodev wolodev commented Nov 19, 2023

πŸ”— Linked issue

Resolves #560

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #560
setResponseStatus didn't work when no content was returned from eventHandler

πŸ“ Checklist

  • [ X] I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (7a8209b) 83.83% compared to head (395bdfe) 83.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   83.83%   83.85%   +0.02%     
==========================================
  Files          31       31              
  Lines        3563     3568       +5     
  Branches      543      547       +4     
==========================================
+ Hits         2987     2992       +5     
  Misses        576      576              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 changed the title bugfix: returning null doesnt override status code fix(sendNoContent): preserve custom status code if already set Nov 20, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pi0 pi0 merged commit 065a4df into unjs:main Nov 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Returning null overrides status code
2 participants