Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use H3Event.node.res for internal types #626

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

GalacticHypernova
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Since some properties were marked as deprecated and have the possibility of being removed in a major update, we shouldn't rely on them for types.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@GalacticHypernova GalacticHypernova marked this pull request as draft January 21, 2024 15:39
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (8345c1f) 77.80% compared to head (3704fa4) 77.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #626   +/-   ##
=======================================
  Coverage   77.80%   77.80%           
=======================================
  Files          47       47           
  Lines        4281     4281           
  Branches      610      610           
=======================================
  Hits         3331     3331           
  Misses        933      933           
  Partials       17       17           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@GalacticHypernova GalacticHypernova marked this pull request as ready for review January 21, 2024 15:41
@pi0 pi0 changed the title chore: don't use deprecated props refactor: use H3Event.node.res for internal types Jan 24, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 84f6806 into unjs:main Jan 24, 2024
6 checks passed
@GalacticHypernova GalacticHypernova deleted the patch-4 branch January 24, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants