Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid setting default content-type for responses with 304 status #641

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jan 25, 2024

  • test: add failing test
  • fix: avoid setting default content-type for responses with 304 status

πŸ”— Linked issue

resolves #603

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (8345c1f) 77.80% compared to head (18c85ea) 77.82%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
+ Coverage   77.80%   77.82%   +0.02%     
==========================================
  Files          47       47              
  Lines        4281     4285       +4     
  Branches      610      611       +1     
==========================================
+ Hits         3331     3335       +4     
  Misses        933      933              
  Partials       17       17              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 merged commit 44445de into main Jan 25, 2024
6 of 7 checks passed
@pi0 pi0 deleted the fix/304-res branch January 25, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default content-type text/html used in 304 responses of static assets
1 participant