Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxy): ignore incoming accept header #646

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix(proxy): ignore incoming accept header #646

merged 1 commit into from
Jan 29, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#24742
resolves nuxt/nuxt#24609
resolves nuxt/nuxt#23539

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This avoids proxying accept headers when fetching with event. Alternatively we could support an option via final argument to add additional headers to ignore, if you prefer.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jan 29, 2024
@danielroe danielroe requested a review from pi0 January 29, 2024 12:07
@danielroe danielroe self-assigned this Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (da128d8) 77.82% compared to head (2f65cdc) 77.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #646   +/-   ##
=======================================
  Coverage   77.82%   77.83%           
=======================================
  Files          47       47           
  Lines        4285     4286    +1     
  Branches      611      608    -3     
=======================================
+ Hits         3335     3336    +1     
  Misses        933      933           
  Partials       17       17           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 changed the title fix: do not proxy accept header in fetchWithEvent fix(proxy): ignore incoming accept header Jan 29, 2024
@pi0 pi0 merged commit e38d444 into main Jan 29, 2024
6 of 7 checks passed
@pi0 pi0 deleted the fix/accept-header branch January 29, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants