Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for return types on callHook/callHookParallel #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Add support for return types on callHook/callHookParallel #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/hookable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ type InferSpyEvent<HT extends Record<string, any>> = {
context: Record<string, any>;
};
}[keyof HT];
type Promisify<T> = T extends Promise<infer U> ? Promise<U> : Promise<T>

export class Hookable<
HooksT extends Record<string, any> = Record<string, HookCallback>,
Expand Down Expand Up @@ -189,15 +190,15 @@ export class Hookable<
callHook<NameT extends HookNameT>(
name: NameT,
...arguments_: Parameters<InferCallback<HooksT, NameT>>
): Promise<any> {
): Promisify<ReturnType<InferCallback<HooksT, NameT>>> {
arguments_.unshift(name);
return this.callHookWith(serialTaskCaller, name, ...arguments_);
}

callHookParallel<NameT extends HookNameT>(
name: NameT,
...arguments_: Parameters<InferCallback<HooksT, NameT>>
): Promise<any[]> {
): Promisify<ReturnType<InferCallback<HooksT, NameT>>> {
arguments_.unshift(name);
return this.callHookWith(parallelTaskCaller, name, ...arguments_);
}
Expand Down