Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix development in windows #135

Merged
merged 8 commits into from
Jul 4, 2023
Merged

Conversation

userquin
Copy link
Contributor

@userquin userquin commented Apr 5, 2023

Trying to build jiti on Windows fails, it is using rm -rf dist... replace it with rimraf.

@pi0
Copy link
Member

pi0 commented Apr 5, 2023

We might instead use pnpm's shell emulator

@userquin
Copy link
Contributor Author

userquin commented Apr 5, 2023

We might instead use pnpm's shell emulator

It is not working, I'm missing something? We can remove cross-env enabling shell-emulator (thx Daniel).

imagen

@userquin
Copy link
Contributor Author

userquin commented Apr 6, 2023

included shell emulator and removed cross-env dependency

@danielroe
Copy link
Member

Any chance you could resolve the merge conflicts? 🙏

@userquin
Copy link
Contributor Author

sure

@userquin userquin requested a review from danielroe May 24, 2023 18:55
@danielroe danielroe requested a review from pi0 June 5, 2023 15:23
@pi0 pi0 changed the title fix: Windows build chore: fix development in windows Jun 6, 2023
@pi0 pi0 merged commit dcf8e0d into unjs:main Jul 4, 2023
2 checks passed
@pi0 pi0 mentioned this pull request Aug 9, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants