Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose jiti.evalModule #146

Merged
merged 7 commits into from
Jul 4, 2023
Merged

feat: expose jiti.evalModule #146

merged 7 commits into from
Jul 4, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jul 4, 2023

πŸ”— Linked issue

#137

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Rework of #139, great idea by @hairyf to expose internal eval function to eval any code

Co-Authored-By: Mr.Mao <951416545@qq.com>

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit a948f82 into main Jul 4, 2023
2 checks passed
@pi0 pi0 deleted the feat/eval-fn branch July 4, 2023 12:15
Comment on lines +339 to +340
const ext = evalOptions.ext || extname(filename);
const cache = (opts.cache || parentCache || {}) as ModuleCache;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because

const x: string = 'x';

(x || {}) as Record<string, any>

compiles, it would be much safer to type it like this:

const cache = (opts.cache as ModuleCache || parentCache || {} as ModuleCache);

or even better:

const cache: ModuleCache = opts.cache || parentCache || {};

This way it would error that opts.cache does not match ModuleCache.

Copy link
Member Author

@pi0 pi0 Jul 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to open a refactor PR? πŸ‘πŸΌ

@pi0 pi0 mentioned this pull request Aug 9, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants