feat: option to show baseURL in showURL
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
CI unrelated, fix in #29 |
pi0
reviewed
Jun 9, 2022
pi0
reviewed
Jun 13, 2022
src/index.ts
Outdated
| const add = opts.clipboard ? gray('(copied to clipboard)') : '' | ||
| const lines = [] | ||
| lines.push(` > Local: ${formatURL(url)} ${add}`) | ||
| const baseURL = (options?.baseURL || opts.baseURL || '').slice(1) |
There was a problem hiding this comment.
We can use ufo.withoutLeadingSlash instead of slice to handle cases without leading / (or ufo.joinURL to join :)
pi0
changed the title
showURLshowURL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.