Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update QR code padding #105

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix: update QR code padding #105

merged 1 commit into from
Aug 14, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Aug 14, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Since we changed a arrow from -> to β†’, it has one offset off now 🫣

image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #105 (8aa47ad) into main (3031763) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   50.93%   50.93%           
=======================================
  Files          10       10           
  Lines        1612     1612           
  Branches      115      115           
=======================================
  Hits          821      821           
  Misses        791      791           
Files Changed Coverage Ξ”
src/listen.ts 83.72% <0.00%> (ΓΈ)

@pi0 pi0 changed the title fix: update QR Code padding fix: update QR code padding Aug 14, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example of ocd: type πŸ˜† πŸ’―

@pi0 pi0 merged commit af6ea3a into main Aug 14, 2023
3 of 4 checks passed
@pi0 pi0 deleted the antfu-patch-1 branch August 14, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants