Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: show QR code above listening URLs #115

Merged
merged 1 commit into from
Aug 27, 2023
Merged

refactor: show QR code above listening URLs #115

merged 1 commit into from
Aug 27, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 27, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

on smaller terminal screens, qr code hides the important URL information. Showing it above helps it.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title refactor/qr place refactor: show QR code above listening URLs Aug 27, 2023
@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #115 (c3d3a8f) into main (9bc3135) will decrease coverage by 0.06%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   51.55%   51.49%   -0.06%     
==========================================
  Files          10       10              
  Lines        1670     1670              
  Branches      128      128              
==========================================
- Hits          861      860       -1     
- Misses        809      810       +1     
Files Changed Coverage Ξ”
src/listen.ts 81.97% <25.00%> (-0.36%) ⬇️

@pi0 pi0 merged commit e47d221 into main Aug 27, 2023
2 of 4 checks passed
@pi0 pi0 deleted the refactor/qr-place branch August 27, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant