Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tidy up open, wsl, and docker utils #118

Merged
merged 1 commit into from
Aug 30, 2023
Merged

refactor: tidy up open, wsl, and docker utils #118

merged 1 commit into from
Aug 30, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 30, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Listhen uses an inline fork of open mainly to have bundler friendly xdg-open but later i end up with several improvements and inlining small libs to reduce size.

This PR, adds full type check, splits wsl and docker utils (i needed them for next steps) and remove many of the dead code from open as we simply need os open functionality.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title refactor: tidy up open, wsl, and docker utils refactor: tidy up open, wsl, and docker utils Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #118 (f039645) into main (38e35b7) will increase coverage by 4.90%.
Report is 1 commits behind head on main.
The diff coverage is 16.88%.

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   51.49%   56.40%   +4.90%     
==========================================
  Files          10       12       +2     
  Lines        1670     1452     -218     
  Branches      128      126       -2     
==========================================
- Hits          860      819      -41     
+ Misses        810      633     -177     
Files Changed Coverage Ξ”
src/lib/open.ts 14.63% <14.63%> (ΓΈ)
src/lib/wsl.ts 17.33% <17.33%> (ΓΈ)
src/lib/docker.ts 25.92% <25.92%> (ΓΈ)

@pi0 pi0 merged commit c64fc61 into main Aug 30, 2023
3 of 4 checks passed
@pi0 pi0 deleted the refactor/lib branch August 30, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant