Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use ipv4 for windows and wsl default hosts #119

Merged
merged 1 commit into from
Aug 30, 2023
Merged

fix: use ipv4 for windows and wsl default hosts #119

merged 1 commit into from
Aug 30, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 30, 2023

πŸ”— Linked issue

Reports in nuxt/cli#109

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Windows IP stack can confuse for resolving localhost between IPv4 and IPv6 stacks.

For more safety, i also changed to prefer IPv4 anyhost (0.0.0.0) by default for windows. (It can be always overridden by users using hostname and HOST)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit 9418ae2 into main Aug 30, 2023
2 checks passed
@pi0 pi0 deleted the wsl-host branch August 30, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant