Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open browser on wsl #124

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix: open browser on wsl #124

merged 1 commit into from
Sep 13, 2023

Conversation

stafyniaksacha
Copy link
Contributor

πŸ”— Linked issue

Resolves #123

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

getWslDrivesMountPoint was returning a function, which then send to childProcess.span, which results in an error:

image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❀️

@pi0 pi0 merged commit 2d3b7b7 into unjs:main Sep 13, 2023
2 checks passed
@stafyniaksacha stafyniaksacha deleted the patch-1 branch September 14, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open the URL in the browser - uncaughtException in WSL environment
2 participants