Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default portRange #63

Merged
merged 2 commits into from
Mar 13, 2023
Merged

fix: add default portRange #63

merged 2 commits into from
Mar 13, 2023

Conversation

Atinux
Copy link
Member

@Atinux Atinux commented Mar 13, 2023

Resolves #62

@Atinux Atinux requested a review from pi0 March 13, 2023 11:27
src/index.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #63 (4de78a1) into main (b7cf9ad) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   54.18%   54.24%   +0.05%     
==========================================
  Files           3        3              
  Lines         836      837       +1     
  Branches       58       58              
==========================================
+ Hits          453      454       +1     
  Misses        383      383              
Impacted Files Coverage Δ
src/index.ts 93.97% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix and also adding tests!

@pi0 pi0 merged commit 9481c97 into main Mar 13, 2023
@pi0 pi0 deleted the fix/port-range branch March 13, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression with random port used
2 participants