Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve watcher experience #82

Merged
merged 10 commits into from
Aug 2, 2023
Merged

feat: improve watcher experience #82

merged 10 commits into from
Aug 2, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 2, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR uses @parcel/watcher to watch all app directory (dirname(entry)) for changes. We could alternatively use to watch dependency graph of entry but it could be unstable and not possible currently since jiti is not exposing the cache.

Error handling and better resolve ordering with time measurement also added.

image image image

(/cc @Atinux some nostalgia here haha)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title feat/recursive watch feat(watcher): use @parcel/watcher to watch entire app directory Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #82 (19ed49a) into main (cd9f66a) will decrease coverage by 6.91%.
Report is 1 commits behind head on main.
The diff coverage is 2.97%.

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   52.84%   45.93%   -6.91%     
==========================================
  Files           7        7              
  Lines         933     1082     +149     
  Branches       55       55              
==========================================
+ Hits          493      497       +4     
- Misses        440      585     +145     
Files Changed Coverage Ξ”
src/watch.ts 4.91% <1.88%> (-11.75%) ⬇️
src/_utils.ts 71.28% <12.50%> (-4.25%) ⬇️
src/types.ts 100.00% <100.00%> (ΓΈ)

@pi0 pi0 changed the title feat(watcher): use @parcel/watcher to watch entire app directory feat(watcher): improve experience Aug 2, 2023
@pi0 pi0 changed the title feat(watcher): improve experience feat: improve watcher experience Aug 2, 2023
@pi0 pi0 merged commit d5bf13e into main Aug 2, 2023
2 of 4 checks passed
@pi0 pi0 deleted the feat/recursive-watch branch August 2, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant