Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dev server with serve static support #83

Merged
merged 8 commits into from
Aug 2, 2023
Merged

feat: dev server with serve static support #83

merged 8 commits into from
Aug 2, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 2, 2023

πŸ”— Linked issue

resolves #38

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Lots of reactors on watcher implementation + ability to automatically serve public directory in server directory.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #83 (ddd7759) into main (d5bf13e) will decrease coverage by 2.88%.
The diff coverage is 11.14%.

❗ Current head ddd7759 differs from pull request most recent head 3d27618. Consider uploading reports for the commit 3d27618 to get more accurate results

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   45.93%   43.06%   -2.88%     
==========================================
  Files           7       10       +3     
  Lines        1082     1189     +107     
  Branches       55       55              
==========================================
+ Hits          497      512      +15     
- Misses        585      677      +92     
Files Changed Coverage Ξ”
src/_utils.ts 100.00% <ΓΈ> (+28.71%) ⬆️
src/types.ts 100.00% <ΓΈ> (ΓΈ)
src/server/_resolver.ts 6.06% <6.06%> (ΓΈ)
src/server/dev.ts 7.94% <7.94%> (ΓΈ)
src/server/watcher.ts 18.29% <18.29%> (ΓΈ)
src/index.ts 100.00% <100.00%> (ΓΈ)
src/server/index.ts 100.00% <100.00%> (ΓΈ)

@pi0 pi0 marked this pull request as ready for review August 2, 2023 21:13
@pi0 pi0 merged commit 3622418 into main Aug 2, 2023
2 checks passed
@pi0 pi0 deleted the feat/serve-static branch August 2, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serve static support
1 participant