Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print qr code for public address #89

Merged
merged 4 commits into from
Aug 12, 2023
Merged

feat: print qr code for public address #89

merged 4 commits into from
Aug 12, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Aug 4, 2023

πŸ”— Linked issue

close #87

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR also expose new utils getURLs for structure data of the URLs, so the user could render URLs in their own format if needed.

Screenshot 2023-08-04 at 17 33 04

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #89 (bb4d04a) into main (11391e8) will increase coverage by 1.94%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   49.75%   51.69%   +1.94%     
==========================================
  Files          10       10              
  Lines        1415     1472      +57     
  Branches      101      110       +9     
==========================================
+ Hits          704      761      +57     
  Misses        711      711              
Files Changed Coverage Ξ”
src/listen.ts 93.29% <100.00%> (+1.79%) ⬆️
src/types.ts 100.00% <100.00%> (ΓΈ)

const firstPublicIPv4 = urls.find(
(url) => url.public && url.type === "ipv4",
);
if (firstPublicIPv4 && options?.qrcode !== false) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might adjust this change this behavior for be for non test/ci and also when public IP is enabled.

@pi0 pi0 changed the title feat: print QR Code for public IPv4 feat: print qr code for public adress Aug 12, 2023
@pi0 pi0 changed the title feat: print qr code for public adress feat: print qr code for public address Aug 12, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ”₯

@pi0 pi0 merged commit 745a34a into main Aug 12, 2023
4 checks passed
@pi0 pi0 deleted the feat/qrcode branch August 12, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support QR code displaying in CLI
2 participants