Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): try to resolve h3 from user node_modules first #94

Merged
merged 4 commits into from
Aug 12, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 12, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix/optional h3 fix(dev): try to load h3 from user first Aug 12, 2023
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #94 (196db15) into main (c3689ce) will decrease coverage by 0.11%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   49.85%   49.75%   -0.11%     
==========================================
  Files          10       10              
  Lines        1410     1415       +5     
  Branches      101      101              
==========================================
+ Hits          703      704       +1     
- Misses        707      711       +4     
Files Changed Coverage Ξ”
src/server/dev.ts 7.65% <16.66%> (+0.26%) ⬆️

@pi0 pi0 changed the title fix(dev): try to load h3 from user first fix(dev): try to resolve h3 from user node_modules first Aug 12, 2023
@pi0 pi0 merged commit 11391e8 into main Aug 12, 2023
2 of 4 checks passed
@pi0 pi0 deleted the fix/optional-h3 branch August 12, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant