Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: qr and publicURL options and --qr, --no-qr, and --public-url cli flags #97

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 12, 2023

  • refactor: better watcher warning message
  • refactor: fix option types and handling
  • feat: top level qr and publicURL options and cli flags

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title feat: qr, --qr, --no-qr and publicURL, --public-url options and cli flags feat: qr and publicURL options and --qr, --no-qr, and --public-url cli flags Aug 12, 2023
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #97 (a2aba1b) into main (ad82a70) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   51.47%   51.70%   +0.22%     
==========================================
  Files          10       10              
  Lines        1490     1497       +7     
  Branches      111      111              
==========================================
+ Hits          767      774       +7     
  Misses        723      723              
Files Changed Coverage Ξ”
src/listen.ts 92.71% <100.00%> (+0.10%) ⬆️
src/types.ts 100.00% <100.00%> (ΓΈ)

@pi0 pi0 merged commit aba93a8 into main Aug 12, 2023
4 checks passed
@pi0 pi0 deleted the feat/top-level branch August 12, 2023 15:32
@pi0 pi0 mentioned this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant