Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stackblitz auto url detection (experimental) #99

Merged
merged 9 commits into from
Aug 12, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 12, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR enables an experimental behavior where as we auto-detect publicURL for stack blitz environment and show it in CLI output.

This is a really hacky implementation implicitly based on internal behavior and environment variables (and naming) of stackblitz. I will have to check with their team how to improve (or remove it!)

https://stackblitz.com/~/github.com/unjs/listhen/pull/99

image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #99 (c304b18) into main (70cc93a) will increase coverage by 0.26%.
The diff coverage is 59.64%.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   49.67%   49.93%   +0.26%     
==========================================
  Files          10       10              
  Lines        1516     1568      +52     
  Branches      101      108       +7     
==========================================
+ Hits          753      783      +30     
- Misses        763      785      +22     
Files Changed Coverage Ξ”
src/server/dev.ts 7.46% <0.00%> (-0.04%) ⬇️
src/server/watcher.ts 14.70% <0.00%> (-0.45%) ⬇️
src/_utils.ts 56.09% <59.09%> (+3.46%) ⬆️
src/listen.ts 83.33% <100.00%> (+0.22%) ⬆️
src/types.ts 100.00% <100.00%> (ΓΈ)

@pi0 pi0 marked this pull request as ready for review August 12, 2023 17:33
@pi0 pi0 merged commit 56173e5 into main Aug 12, 2023
4 checks passed
@pi0 pi0 deleted the feat/stackblitz branch August 12, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant