Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(proxy): append request query params for single proxy route rules #1163

Merged
merged 4 commits into from Apr 17, 2023
Merged

fix(proxy): append request query params for single proxy route rules #1163

merged 4 commits into from Apr 17, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Apr 17, 2023

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

When a routeing rule like /proxy: { proxy: 'to' } exists, the query params was being ignored. Added fix + tests. (thanks @Atinux for reporting)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Atinux
Atinux approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@Atinux Atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@pi0 pi0 marked this pull request as ready for review April 17, 2023 18:16
@pi0 pi0 merged commit a64dcc5 into main Apr 17, 2023
5 checks passed
@pi0 pi0 deleted the fix/proxy-query branch April 17, 2023 18:44
@pi0 pi0 mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atinux Atinux Atinux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pi0 @Atinux