Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dedup unstorage dependency and use subpath alias #1164

Merged
merged 5 commits into from
Jun 28, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Apr 17, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Similar to other core deps (h3, radix3, defu), unstorage should be deduped otherwise there might be missing chunks in final output (this is not root cause but a common issue and this PR is basically a stable workaround to the issue)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix: dedup unstorage dependency fix: dedup unstorage dependency Apr 17, 2023
@pi0 pi0 changed the title fix: dedup unstorage dependency fix: dedup unstorage dependency and use subpath alias Apr 17, 2023
@pi0 pi0 marked this pull request as draft April 17, 2023 18:36
@pi0
Copy link
Member Author

pi0 commented Apr 17, 2023

Need to test more

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #1164 (b3fe8fb) into main (e580751) will decrease coverage by 0.05%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##             main    #1164      +/-   ##
==========================================
- Coverage   76.58%   76.53%   -0.05%     
==========================================
  Files          70       70              
  Lines        7182     7193      +11     
  Branches      714      714              
==========================================
+ Hits         5500     5505       +5     
- Misses       1681     1686       +5     
- Partials        1        2       +1     
Impacted Files Coverage Ξ”
src/options.ts 94.13% <86.66%> (-0.32%) ⬇️

... and 1 file with indirect coverage changes

@pi0 pi0 requested a review from danielroe June 12, 2023 11:06
@danielroe
Copy link
Member

Do you have an example reproduction?

@pi0 pi0 marked this pull request as ready for review June 28, 2023 10:07
@pi0
Copy link
Member Author

pi0 commented Jun 28, 2023

Do you have an example reproduction?

Unofrountaly not a stable one but this has been reported many times, especially within the Nuxt ecosystem.

I am thinking to move it forward since this way of aliasing is better anyway by not pre-applying resolve conditions.

@pi0 pi0 merged commit 20c841c into main Jun 28, 2023
7 checks passed
@pi0 pi0 deleted the fix/unstorage-pin branch June 28, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants