Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: future.nativeSWR #1212

Merged
merged 1 commit into from May 5, 2023
Merged

feat: future.nativeSWR #1212

merged 1 commit into from May 5, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 5, 2023

πŸ”— Linked issue

Uses built-in SWR functionality (using caching layer and storage) for Netlify and Vercel presets instead of falling back to ISR behavior.

New future namespace will be used for potentially breaking but stable changes with an opt-in method until next major nitro versions. This way we can better collaborate with consumer frameworks such as Nuxt.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 requested a review from danielroe May 5, 2023 16:39
@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented May 5, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview 18d9fe5

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #1212 (18d9fe5) into main (f9c833c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1212      +/-   ##
==========================================
+ Coverage   77.29%   77.33%   +0.04%     
==========================================
  Files          67       67              
  Lines        6642     6654      +12     
  Branches      681      681              
==========================================
+ Hits         5134     5146      +12     
  Misses       1507     1507              
  Partials        1        1              
Impacted Files Coverage Ξ”
src/options.ts 96.42% <100.00%> (+<0.01%) ⬆️
src/presets/netlify.ts 78.63% <100.00%> (+0.39%) ⬆️
src/presets/vercel.ts 93.92% <100.00%> (+0.08%) ⬆️
src/types/nitro.ts 100.00% <100.00%> (ΓΈ)

@pi0 pi0 merged commit 65665a4 into main May 5, 2023
7 checks passed
@pi0 pi0 deleted the feat/future-swr branch May 5, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants