Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prerender): allow to fetch static files #1340

Merged
merged 1 commit into from
Jun 23, 2023
Merged

fix(prerender): allow to fetch static files #1340

merged 1 commit into from
Jun 23, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jun 23, 2023

πŸ”— Linked issue

nuxt/nuxt#21722

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This allows access to static files whilst prerendering - which I think would be a common use case.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jun 23, 2023
@danielroe danielroe requested a review from pi0 June 23, 2023 15:12
@danielroe danielroe self-assigned this Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #1340 (ba2772c) into main (ed69bae) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1340      +/-   ##
==========================================
+ Coverage   76.62%   76.68%   +0.05%     
==========================================
  Files          70       70              
  Lines        7161     7162       +1     
  Branches      709      710       +1     
==========================================
+ Hits         5487     5492       +5     
+ Misses       1672     1669       -3     
+ Partials        2        1       -1     
Impacted Files Coverage Ξ”
src/presets/nitro-prerender.ts 100.00% <100.00%> (ΓΈ)

... and 1 file with indirect coverage changes

@pi0 pi0 changed the title fix: allow prerenderer to access static files fix(prerender): allow to access static files Jun 23, 2023
@pi0 pi0 changed the title fix(prerender): allow to access static files fix(prerender): allow to fetch static files Jun 23, 2023
@pi0 pi0 merged commit e77e0ed into main Jun 23, 2023
7 checks passed
@pi0 pi0 deleted the fix/static-prerender branch June 23, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants