fix(firebase): use correct key when importing firebase httpsOptions

[luc122c]

🔗 Linked issue

fix #1655
#1657
#1556
#1555

❓ Type of change

• 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The correct key is httpsOptions, however, httpOptions was being pulled in. I searched for httpOptions and this appeared to be the only remaining instance. I believe this is the root fix for #1655

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[codecov]

Codecov Report

Merging #1663 (27c47a7) into main (83e980b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1663   +/-   ##
=======================================
  Coverage   77.79%   77.79%           
=======================================
  Files          76       76           
  Lines        7836     7836           
  Branches      805      805           
=======================================
  Hits         6096     6096           
  Misses       1738     1738           
  Partials        2        2           

[Hebilicious]

@posva do we need both setGlobalOptions and the options being passed there ?

[luc122c]

@Hebilicious I think #1657 is a workaround and would no longer be required. This if statement pulls from httpsOptions, which is the correct key, which is probably why it works. Setting the global options should not be necessary.

[posva]

I don’t think both are needed but since it was in docs I supposed the préfères way just changed and using the global options changed

[y-takebe]

Hi everyone!

I have confirmed that the code modified in this PR works as expected with regions, minInstances, etc. In this case,setGlobalOptions is not needed.

Alternatively, I have also confirmed that setting all options in setGlobalOptions works fine.

setGlobalOptions(
  firebaseConfig.httpsOptions
);

export const __firebaseServerFunctionName__ = onRequest(
  {
    // Must be set to public to allow all public requests by default
    invoker: "public",
  },
  toNodeListener(nitroApp.h3App)
);

There is no need to have both, so choose one or the other.

[pi0]

Thanks ❤️ I appreciate if you can confirm this PR using edge release channel if had a chance.

[luc122c]

@pi0 I'm on the edge release Nuxt 3.7.0 with Nitro 2.6.3-28226639.ab15724 but my output is still showing the incorrect httpOptions. I deleted node_modules, yarn.lock, .nuxt and .output and did a fresh build but my .output/server/chunks/nitro/firebase-gen-2.mjs still looks like this:

const nitroApp = createNitroApp();
const useNitroApp = () => nitroApp;

const firebaseConfig = useAppConfig().nitro.firebase;
const server = onRequest(
  {
    // Must be set to public to allow all public requests by default
    invoker: "public",
    ...firebaseConfig.httpOptions
  },
  toNodeListener(nitroApp.h3App)
);

The Nitro config for this project is:

  nitro: {
    preset: "firebase",
    firebase: {
      gen: 2,
      nodeVersion: "18",
      httpsOptions: {
        region: "us-east1",
      },
    },
  },

Any ideas on what to check?

[pi0]

@luc122c Are you using resolutions field? (feel free to DM me @pi0 in discord!)

[luc122c]

@pi0 , no it's in the devDependencies. I've messaged you :)

Edit: It works in resolutions, the region now gets factored in correctly.