Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve output dirs relative to rootDir #1666

Merged
merged 1 commit into from Aug 29, 2023
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Aug 29, 2023

πŸ”— Linked issue

resolves nuxt/nuxt#22038

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Debugging another issue (nuxt/nuxt#22038) noticed that output dirs were being resolved relative to srcDir in the absence of an explicit base.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Aug 29, 2023
@danielroe danielroe requested a review from pi0 August 29, 2023 14:14
@danielroe danielroe self-assigned this Aug 29, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’― (waiting for ci to pass)

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1666 (625c621) into main (19916e0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1666   +/-   ##
=======================================
  Coverage   77.77%   77.78%           
=======================================
  Files          76       76           
  Lines        7824     7827    +3     
  Branches      803      804    +1     
=======================================
+ Hits         6085     6088    +3     
  Misses       1737     1737           
  Partials        2        2           
Files Changed Coverage Ξ”
src/options.ts 96.99% <100.00%> (+0.01%) ⬆️

@pi0 pi0 merged commit 2a33f1f into main Aug 29, 2023
9 checks passed
@pi0 pi0 deleted the fix/output-root-relative branch August 29, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bad nitro publicDir when dir.public is modified
2 participants