Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update test for bun headers #1684

Merged
merged 3 commits into from Sep 1, 2023
Merged

test: update test for bun headers #1684

merged 3 commits into from Sep 1, 2023

Conversation

Hebilicious
Copy link
Member

@Hebilicious Hebilicious commented Sep 1, 2023

πŸ”— Linked issue

Resolves #1461

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I was able to run the header tests locally for bun 0.8.1. However the same tests appear to be failing with the CI.
Investigating, I'm able to make the tests fail locally by downgrading my node version to 16, which match the CI behaviour.
I'm not sure why this is happening, but we can handle this the same way we handle deno

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Hebilicious Hebilicious changed the title test/bun cookies test(bun): add headers test for bun Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #1684 (4a4c519) into main (3315c99) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1684   +/-   ##
=======================================
  Coverage   77.79%   77.79%           
=======================================
  Files          76       76           
  Lines        7836     7836           
  Branches      805      805           
=======================================
  Hits         6096     6096           
  Misses       1738     1738           
  Partials        2        2           

@Hebilicious Hebilicious marked this pull request as ready for review September 1, 2023 19:28
@Hebilicious Hebilicious requested a review from pi0 September 1, 2023 19:28
@pi0 pi0 changed the title test(bun): add headers test for bun test: update test for bun headers Sep 1, 2023
@pi0 pi0 merged commit ab15724 into main Sep 1, 2023
9 checks passed
@pi0 pi0 deleted the test/bun-cookies branch September 1, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bun preset does not handles set cookies
2 participants