Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve actual subpaths before guessing #527

Merged
merged 14 commits into from Aug 7, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This resolves actual subpaths rather than guessing, so (for example) node-fetch-native/dist/polyfill.mjs can correctly be resolved to node-fetch-native/polyfill and back again.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #527 (133f2bd) into main (99fbfb9) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #527      +/-   ##
==========================================
- Coverage   76.50%   76.48%   -0.03%     
==========================================
  Files          73       73              
  Lines        7594     7578      -16     
  Branches      755      750       -5     
==========================================
- Hits         5810     5796      -14     
+ Misses       1783     1781       -2     
  Partials        1        1              
Files Changed Coverage Ξ”
src/rollup/plugins/externals.ts 93.27% <100.00%> (+0.16%) ⬆️

@danielroe
Copy link
Member Author

If you like this approach we can also extract into a mlly util.

@pi0
Copy link
Member

pi0 commented Sep 26, 2022

A refactor to mlly would be nice idea for reverse resolving subpaths πŸ‘πŸΌ

@Hebilicious
Copy link
Member

@danielroe is this ready to review ?

@danielroe
Copy link
Member Author

It is.

Hebilicious
Hebilicious previously approved these changes Jul 4, 2023
@Hebilicious
Copy link
Member

Hebilicious commented Jul 4, 2023

@danielroe Had to create a new branch to fix the conflicts. You can force push from there #1395
This looks good to me, altough I'm not really a rollup wizard like you πŸ’‡πŸ½

@danielroe
Copy link
Member Author

danielroe commented Jul 5, 2023

I don't believe there are any conflicts in this branch. I resolved them 5 days ago with a rebase.

@danielroe danielroe requested a review from pi0 July 5, 2023 06:18
Copy link
Member

Ah yes ignore me 🀦 GitHub UI fooled me

@pi0 pi0 merged commit 2483789 into main Aug 7, 2023
9 checks passed
@pi0 pi0 deleted the feat/actual-subpaths branch August 7, 2023 22:38
@pi0 pi0 mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants