fix(basename): handle empty extensions (#61)

unjs · Sep 15, 2022 · b0661cb · b0661cb
1 parent e9f50b7
commit b0661cb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/path.ts b/src/path.ts
@@ -218,7 +218,7 @@ export const format: typeof path.format = function (p) {
 // basename
 export const basename: typeof path.basename = function (p, ext) {
   const lastSegment = normalizeWindowsPath(p).split('/').pop()
-  return lastSegment.endsWith(ext) ? lastSegment.slice(0, -ext.length) : lastSegment
+  return ext && lastSegment.endsWith(ext) ? lastSegment.slice(0, -ext.length) : lastSegment
 }
 
 // parse

diff --git a/test/index.spec.ts b/test/index.spec.ts
@@ -62,12 +62,14 @@ runTest('basename', basename, [
   ['/temp/myfile.html', 'myfile.html'],
   ['./myfile.html', 'myfile.html'],
   ['./myfile.html', '.html', 'myfile'],
+  ['./undefined', undefined, 'undefined'],
 
   // Windows
   ['C:\\temp\\myfile.html', 'myfile.html'],
   ['\\temp\\myfile.html', 'myfile.html'],
   ['.\\myfile.html', 'myfile.html'],
-  ['.\\myfile.html', '.html', 'myfile']
+  ['.\\myfile.html', '.html', 'myfile'],
+  ['.\\undefined', undefined, 'undefined']
 ])
 
 runTest('dirname', dirname, {