fix(extname): handle edge cases wirth leading dot

resolves #21
unjs · Jun 29, 2022 · dfe46d7 · dfe46d7
1 parent d6fa1f2
commit dfe46d7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/path.ts b/src/path.ts
@@ -182,9 +182,10 @@ export const toNamespacedPath: typeof path.toNamespacedPath = function (p) {
 }
 
 // extname
+const _EXTNAME_RE = /(?<!^)\.[^/.]+$/
 export const extname: typeof path.extname = function (p) {
-  const segments = normalizeWindowsPath(p).split('/').pop().split('.')
-  return segments.length > 1 ? `.${segments.pop()}` : ''
+  const match = _EXTNAME_RE.exec(normalizeWindowsPath(p))
+  return (match && match[0]) || ''
 }
 
 // relative

diff --git a/test/index.spec.ts b/test/index.spec.ts
@@ -61,6 +61,14 @@ runTest('extname', extname, {
   '/temp/myfile.html': '.html',
   './myfile.html': '.html',
 
+  '.foo': '',
+  '..foo': '.foo',
+  'foo.123': '.123',
+  '..': '',
+  '.': '',
+  './': '',
+  // '...': '.', // TODO: Edge case behavior of Node?
+
   // Windows
   'C:\\temp\\myfile.html': '.html',
   '\\temp\\myfile.html': '.html',