Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolveWorkspace, resolveWorkspacePkgs, resolveWorkspacePkgsGraph #118

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

aa900031
Copy link

@aa900031 aa900031 commented Mar 27, 2023

Resolve issue #117

In this PR, I have implement two functions:

  1. resolveWorkspace: that detects explicit monorepo workspaces using the detected field in package.json or pnpm-workspace.yaml, returning a workspaces.
  2. resolveWorkspacePkgs: can also be introduced to accept resolved workspace config and read all of its packages.
  3. resolveWorkspacePkgsGraph: sort packages with topological.

All of the above support: pnpm, lerna, yarn, npm

@aa900031 aa900031 changed the title feat: resolveWorkspace, resolveWorkspacePkgs feat: resolveWorkspace, resolveWorkspacePkgs, resolveWorkspacePkgsGraph Apr 18, 2023
@aa900031
Copy link
Author

Hi @pi0:

I have finished this PR. Please review it, THX

README.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #118 (cd65d0b) into main (8f1ca41) will increase coverage by 1.99%.
The diff coverage is 95.26%.

❗ Current head cd65d0b differs from pull request most recent head e3f0e5c. Consider uploading reports for the commit e3f0e5c to get more accurate results

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   89.40%   91.39%   +1.99%     
==========================================
  Files           5        5              
  Lines         434      616     +182     
  Branches       37       83      +46     
==========================================
+ Hits          388      563     +175     
- Misses         46       53       +7     
Impacted Files Coverage Δ
src/index.ts 85.71% <95.02%> (+13.23%) ⬆️
src/utils.ts 94.05% <100.00%> (-0.90%) ⬇️

@aa900031
Copy link
Author

Hi @danielroe, If you have any questions or concerns, please let me know, Thanks

@Barbapapazes
Copy link
Member

@aa900031, I create a PR in order to fix lint issue on windows aa900031#1.

@aa900031
Copy link
Author

aa900031 commented May 9, 2023

@Barbapapazes Thank you 🙇

@aa900031 aa900031 mentioned this pull request Jun 21, 2023
6 tasks
@aa900031
Copy link
Author

aa900031 commented Jul 12, 2023

@danielroe @pi0 Thank you for review, this feature is crucial for supporting monorepo in changelogen. If possible, please merge it as soon as you can.

If there is any question, please let me know.

@aa900031
Copy link
Author

@danielroe @pi0 I've submitted this pull request (PR) a while ago and noticed that it hasn't received any attention.

I wanted to ask if you think this feature is necessary? If it's not needed, I'm considering implementing it myself instead of relying on unjs. I would appreciate a response.

@Hebilicious Hebilicious requested a review from pi0 August 14, 2023 07:01
@pi0
Copy link
Member

pi0 commented Aug 14, 2023

@aa900031 definitely this s a nice PR and also required for us! I need to refactor some changes before merging to the main.

@pi0 pi0 marked this pull request as draft April 17, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants