Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): support object format for PackageJson .browser #145

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix(types): support object format for PackageJson .browser #145

merged 1 commit into from
Oct 25, 2023

Conversation

imranbarbhuiya
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

According to https://github.com/defunctzombie/package-browser-field-spec, browser field can be a string, an object with string | false value. This PR adds the object support.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix: browser field type fix(types): support object format for PackageJson .browser Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #145 (d13c222) into main (b1f6536) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   89.40%   89.40%           
=======================================
  Files           5        5           
  Lines         434      434           
  Branches       37       37           
=======================================
  Hits          388      388           
  Misses         46       46           
Files Coverage Ξ”
src/types/packagejson.ts 100.00% <100.00%> (ΓΈ)

@imranbarbhuiya
Copy link
Contributor Author

@pi0 can u please merge this pr as I need it in my project

@danielroe danielroe merged commit 5764ba1 into unjs:main Oct 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants