Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for all lockfiles before ascending directories #179

Merged
merged 3 commits into from
May 9, 2024

Conversation

werheng
Copy link
Contributor

@werheng werheng commented May 9, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When I use findWorkspaceDir without git, it would look for lockfile by resolveLockfile. Finding all format of the lockfile before traverse directory would be better.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this and think it will solve some significant downstream issues - thank you ❀️

@danielroe danielroe changed the title fix: resolve lockfile fix: check for all lockfiles before ascending directories May 9, 2024
@danielroe danielroe requested a review from pi0 May 9, 2024 10:47
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 89.35%. Comparing base (afdf7cb) to head (dd843b1).
Report is 11 commits behind head on main.

Files Patch % Lines
src/index.ts 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   89.40%   89.35%   -0.06%     
==========================================
  Files           5        5              
  Lines         434      554     +120     
  Branches       37       38       +1     
==========================================
+ Hits          388      495     +107     
- Misses         46       59      +13     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’―

@pi0 pi0 merged commit b24c863 into unjs:main May 9, 2024
3 of 4 checks passed
@werheng werheng deleted the fix branch May 10, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants