Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pascalCase, camelCase): move normalize behind a flag #63

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Nov 30, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR moves the changes in #62 behind a flag to reduce ecosystem-breaking changes and unwanted case changes.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
bdehamer Brian DeHamer
Copy link

codecov bot commented Nov 30, 2023 β€’

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (4c9da31) 100.00% compared to head (8f0d2e9) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #63   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          268       295   +27     
  Branches        34        34           
=========================================
+ Hits           268       295   +27     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Verified

This commit was signed with the committer’s verified signature.
bdehamer Brian DeHamer

Verified

This commit was signed with the committer’s verified signature.
bdehamer Brian DeHamer
@pi0 pi0 merged commit e32421a into main Nov 30, 2023
@pi0 pi0 deleted the fix/scule-case branch November 30, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants