fix(isColorSupported): inverted condition for TERM=dumb
#97
+1
β2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
Currently our condition checks for !!TERM=dumb, which means
isColorSupported
will be set to true for terminal that doesn't support color, and vice-versa, isColorSupported is false for supported terminals,this corrects the behavior.
Ref: https://www.npmjs.com/package/color-support
Note: Should it be a breaking change?
π Checklist