Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isColorSupported): inverted condition for TERM=dumb #97

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

NamesMT
Copy link
Contributor

@NamesMT NamesMT commented Nov 24, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently our condition checks for !!TERM=dumb, which means isColorSupported will be set to true for terminal that doesn't support color, and vice-versa, isColorSupported is false for supported terminals,
this corrects the behavior.

Ref: https://www.npmjs.com/package/color-support

Note: Should it be a breaking change?

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@NamesMT NamesMT mentioned this pull request Nov 24, 2023
8 tasks
@pi0 pi0 changed the title fix: isColorSupported inverted condition fix(isColorSupported): inverted condition for TERM=dumb Dec 1, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Verified

This commit was signed with the committer’s verified signature.
thorbenbelow Thorben Below
@pi0 pi0 merged commit b8172a7 into unjs:main Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants