Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stringify protocol-relative URLs #207

Merged
merged 4 commits into from Feb 5, 2024
Merged

fix: stringify protocol-relative URLs #207

merged 4 commits into from Feb 5, 2024

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Feb 5, 2024

πŸ”— Linked issue

resolves nuxt/nuxt#25570

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This is an attempt to fix withQuery behaviour when passed a protocol-relative URL.

withQuery('//router.com', {})
// returns `router.com`

I felt that stringifyParsedURL was the most base level fix but it does change behaviour of 'bare' hostname (seen it test). Thoughts welcome.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 February 5, 2024 12:23
src/parse.ts Outdated Show resolved Hide resolved
@danielroe danielroe self-assigned this Feb 5, 2024
test/utilities.test.ts Outdated Show resolved Hide resolved
@danielroe danielroe requested a review from pi0 February 5, 2024 13:40
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 3cd8c3f into main Feb 5, 2024
2 checks passed
@pi0 pi0 deleted the fix/stringify-proto-rel branch February 5, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

navigateTo redirects to external url, without setting external to true
2 participants