Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add withoutHost utility #212

Merged
merged 7 commits into from Mar 11, 2024
Merged

feat: add withoutHost utility #212

merged 7 commits into from Mar 11, 2024

Conversation

IgnisDa
Copy link
Contributor

@IgnisDa IgnisDa commented Feb 25, 2024

πŸ”— Linked issue

Fixes #211.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Removes the host from the input URL.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@IgnisDa
Copy link
Contributor Author

IgnisDa commented Feb 25, 2024

@pi0 I was unable to get automd working. Should I update the readme manually?

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 98.63%. Comparing base (d283cf5) to head (b02d92f).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   95.27%   98.63%   +3.36%     
==========================================
  Files           7        7              
  Lines         867     1320     +453     
  Branches      187      214      +27     
==========================================
+ Hits          826     1302     +476     
+ Misses         41       18      -23     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0
Copy link
Member

pi0 commented Feb 25, 2024

What was your issue with automd?

@IgnisDa
Copy link
Contributor Author

IgnisDa commented Feb 25, 2024

I have added the relevant jsdocs to the new function. However when I run pnpm automd, it exits successfully without any changes to the readme. I expected it to update the utilities documentation with the new function I added.

@pi0

This comment was marked as off-topic.

@IgnisDa

This comment was marked as off-topic.

@pi0

This comment was marked as off-topic.

@pi0 pi0 changed the title feat: utility to remove host feat: add withoutHost utility Mar 11, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❀️

@pi0 pi0 merged commit aa54b6a into unjs:main Mar 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utility to get url without host (path + query + [hash])
2 participants