Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not throw error on absolute windows paths #166

Merged
merged 1 commit into from Dec 6, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Previously when including package.json or other local file that is resolved to an absolute path, unbuild would identify this as an external on windows systems, as the absolute path didn't start with / but with C:\

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Dec 5, 2022
@danielroe danielroe self-assigned this Dec 5, 2022
@pi0
Copy link
Member

pi0 commented Dec 6, 2022

Thanks!

@pi0 pi0 merged commit 8c57847 into main Dec 6, 2022
@pi0 pi0 deleted the fix/windows-externals branch December 6, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants