Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass missing esbuild jsx factory options #224

Merged
merged 2 commits into from Mar 27, 2023
Merged

fix: pass missing esbuild jsx factory options #224

merged 2 commits into from Mar 27, 2023

Conversation

yjl9903
Copy link
Contributor

@yjl9903 yjl9903 commented Mar 1, 2023

export interface Options {
include?: FilterPattern;
exclude?: FilterPattern;
sourceMap?: boolean;
minify?: boolean;
target: string | string[];
jsxFactory?: string;
jsxFragment?: string;

The type definition is here, but not passing to esbuild transform. And there is another JSX related PR #198.

By the way, I think it is necessary to pass the full esbuild transform options like vite?

https://github.com/vitejs/vite/blob/a1019f80a5d5b6242d8fb0975994ce1ae6e78e94/packages/vite/src/node/plugins/esbuild.ts#L35-L43

There is some related esbuild options PR #190 #192

@pi0 pi0 changed the title fix: miss passing esbuild JSX factory option fix: pass missing esbuild jsx factory options Mar 27, 2023
@pi0 pi0 merged commit b70338d into unjs:main Mar 27, 2023
1 check passed
@pi0
Copy link
Member

pi0 commented Mar 27, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants