Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support nested plugins #176

Merged
merged 14 commits into from Oct 18, 2022
Merged

feat: support nested plugins #176

merged 14 commits into from Oct 18, 2022

Conversation

sxzz
Copy link
Collaborator

@sxzz sxzz commented Oct 13, 2022 •
edited

closes #173

@sxzz sxzz marked this pull request as ready for review October 13, 2022 21:53
antfu
antfu reviewed Oct 13, 2022
View reviewed changes
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have some more tests with nested plugins? Also would be great to have some docs for this, and mentioning it only works with Rollup 3.1 or above.

src/rollup/index.ts Outdated Show resolved Hide resolved
@sxzz
Copy link
Collaborator Author

sxzz commented Oct 14, 2022

@antfu I fixed Webpack issue, and skipped esbuild test, because of no transform stage in esbuild.

I will try to think about a more general way to improve esbuild transform stage. Relate issue #126

@antfu antfu changed the title feat: support multiple plugins feat: support nested plugins Oct 18, 2022
@antfu antfu merged commit d35e055 into unjs:main Oct 18, 2022
@sxzz sxzz deleted the feat/multi-plugins branch October 18, 2022 03:49
@jwr1 jwr1 mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: define multiple sub-plugin in one plugin
2 participants
@sxzz @antfu