Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support nested plugins #176

Merged
merged 14 commits into from
Oct 18, 2022
Merged

feat: support nested plugins #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
311fcee
feat: support multiple plugins
sxzz Oct 13, 2022
edc0319
fix: tests
sxzz Oct 13, 2022
05f98a8
chore: simplify
sxzz Oct 13, 2022
cb924c1
fix: types
sxzz Oct 13, 2022
abf63f4
chore: inline @antfu/utils
sxzz Oct 13, 2022
c61a3ab
refactor: inline `toArray`
antfu Oct 14, 2022
1d510d4
docs: update
antfu Oct 14, 2022
50abe1f
chore: update tests
antfu Oct 14, 2022
0769783
fix: webpack
sxzz Oct 14, 2022
310379a
test: skip
sxzz Oct 14, 2022
c3ed62b
chore: update
antfu Oct 16, 2022
fe2e27e
chore: update
antfu Oct 18, 2022
a9d8e14
Merge branch 'main' into feat/multi-plugins
antfu Oct 18, 2022
e67ca0b
chore: fix table
antfu Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
37 changes: 36 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,42 @@ export const webpackPlugin = unplugin.webpack
export const esbuildPlugin = unplugin.esbuild
```

### Plugin Installation
## Nested Plugins

Since `v0.10.0`, unplugin supports constructing multiple nested plugins to behave like a single one. For example:

###### Supported

| Rollup | Vite | Webpack 4 | Webpack 5 | esbuild |
| :----: | :--: | :-------: | :-------: | :-----: |
| ✅ `>=3.1` | ✅ | ✅ | ✅ | ⚠️<sup>5</sup> |

5. Since esbuild does not have a built-in transform phase, the `transform` hook of nested plugin will not work on esbuild yet. Other hooks like `load` or `resolveId` work fine. We will try to find a way to support it in the future.

###### Usage

```ts
import { createUnplugin } from 'unplugin'

export const unplugin = createUnplugin((options: UserOptions) => {
return [
{
name: 'plugin-a',
transform (code) {
// ...
}
},
{
name: 'plugin-b',
resolveId (id) {
// ...
}
}
]
})
```

## Plugin Installation

###### Vite

Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"@nuxtjs/eslint-config-typescript": "^11.0.0",
"@types/express": "^4.17.14",
"@types/fs-extra": "^9.0.13",
"@types/node": "^18.7.16",
"@types/node": "^18.11.0",
"@types/webpack-sources": "^3.2.0",
"bumpp": "^8.2.1",
"conventional-changelog-cli": "^2.2.2",
Expand All @@ -53,7 +53,7 @@
"jiti": "^1.16.0",
"magic-string": "^0.26.7",
"picocolors": "^1.0.0",
"rollup": "^2.79.1",
"rollup": "^3.2.2",
"tsup": "^6.3.0",
"typescript": "^4.8.4",
"vite": "^3.1.8",
Expand Down
36 changes: 22 additions & 14 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion scripts/buildFixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ async function run () {
execSync('npx vite build', { cwd: path, stdio: 'inherit' })
console.log(c.red(c.inverse(c.bold('\n Rollup '))), name, '\n')
execSync('npx rollup --version', { cwd: path, stdio: 'inherit' })
execSync('npx rollup -c', { cwd: path, stdio: 'inherit' })
execSync('npx rollup --bundleConfigAsCjs -c', { cwd: path, stdio: 'inherit' })
console.log(c.blue(c.inverse(c.bold('\n Webpack '))), name, '\n')
execSync('npx webpack --version', { cwd: path, stdio: 'inherit' })
execSync('npx webpack', { cwd: path, stdio: 'inherit' })
Expand Down