Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: package metadata #106

Closed
wants to merge 3 commits into from
Closed

feat: package metadata #106

wants to merge 3 commits into from

Conversation

Barbapapazes
Copy link
Member

πŸ”— Linked issue

fix #104

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Waiting for #103 before continuing
Waiting for nuxt/content#2280 before merging

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Barbapapazes Barbapapazes self-assigned this Sep 2, 2023
@Barbapapazes Barbapapazes marked this pull request as draft September 2, 2023 10:44
const contributors = await $fetch(`https://ungh.cc/repos/${owner}/${repo}/contributors`)

return contributors.contributors.length
}, { maxAge: 24 * 60 * 60 * 1000 })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think best would be directly fetching from ungh.cc to avoid doubling the caching cost. since we directly deploy to cf network, inter service cost is low.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just for development since we generate the site!

In dev want, I want local cache to avoid to many HTTP calls that could slow down local dev.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. We can try a route rule with proxy and cache (or one handler at leat with return sendProxy). It is not obvious why we are doing it this way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoo, I can combien proxy and cache πŸ‘€

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to rewrite the URL?

nuxt.config.ts Outdated
@@ -56,6 +56,15 @@ export default defineNuxtConfig({
prerender: true,
headers: { 'Content-Type': 'text/xml' }, // By default, Nitro will set the content type to text/html
},
// TODO: missing a way to rewrite the URL
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pi0, how to I can rewrite path to allow the proxy to work?

@Barbapapazes
Copy link
Member Author

continue in #158

@Barbapapazes Barbapapazes deleted the feat/packages-metadata branch November 2, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add stars, weekly downloads and contributors
2 participants