Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new theme #196

Merged
merged 59 commits into from
Dec 29, 2023
Merged

feat: new theme #196

merged 59 commits into from
Dec 29, 2023

Conversation

Barbapapazes
Copy link
Member

@Barbapapazes Barbapapazes commented Nov 30, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • πŸ“° Content (a new article or a change in the content folder)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Light theme
  • Rework filter on mobile using a modal
  • error.vue component
  • add color to the eyebrow
  • rework search
  • rebuild /search
  • fix "There are no articles for the moment."
  • improve home by adding some stats (could add a new section with stars, downloads and packages)
  • rework header and footer
  • Add missing light illustration and puzzle part
  • Add puzzle part to design kit (both light and dark)
  • Add missing og-images (will be done by Harlan in feat: add og-images for packagesΒ #81)
  • Change icons (remove icons from header navigation and the search text to help user to focus on it)
  • Rework margin from hero of /
  • Once an author is selected, order does not work

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Contributor

nuxt-studio bot commented Nov 30, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
unjs-website Edit on Studio β†—οΈŽ View Live Preview b03a189

@Barbapapazes Barbapapazes self-assigned this Nov 30, 2023
app.vue Outdated Show resolved Hide resolved
@harlan-zw
Copy link

harlan-zw commented Dec 2, 2023

Looks good, nice job!

Just some ideas clicking around:

  • add an error.vue page

  • make the search background slightly more opaque

image

  • you're overdoing the boxes a bit too much still, it would make the design a bit fresher if you kept the header / footer in a simpler style. if you're going to use icons for the nav, use a better icon set, maybe carbon, also don't render them as full black, they shouldn't compete with the text

image

(very rough mockup, you'll need to play around with it but lmk if you need help)

  • use a different colour for What's new, see this for inspo

image

  • "There are no articles for the moment." on home page

  • i think you should show the packages stats on the home page to give people a better idea of the scope >53 Packages, 277m
    Monthly Downloads

  • footer search link is broken

In terms of new things I'd like to see on the site:

  • a "philosophy / manifesto" type page that is more in-depth, like the idea behind UnJS, some of the history and context, etc. I believe this content exists somewhere already
  • a "testimonial" section, just linking some of the nice things notable people have said about UnJS
  • a team page

@Barbapapazes
Copy link
Member Author

Thank you for the feedback!

  • a "philosophy / manifesto" type page that is more in-depth, like the idea behind UnJS, some of the history and context, etc. I believe this content exists somewhere already
  • a "testimonial" section, just linking some of the nice things notable people have said about UnJS
  • a team page

This PR will not touch content but clearly, these 3 things are highly wanted. I'll keep them for a next work!

@Barbapapazes
Copy link
Member Author

Barbapapazes commented Dec 3, 2023

@harlan-zw, I've update a lot since your last review.

There is still some illustrations missing and I need to add a section on the home with packages stats (should be done monday). Done πŸŽ‰

@Barbapapazes
Copy link
Member Author

Barbapapazes commented Dec 5, 2023

@Barbapapazes Barbapapazes marked this pull request as ready for review December 11, 2023 07:23
@Barbapapazes Barbapapazes merged commit cd30fc6 into main Dec 29, 2023
7 checks passed
@Barbapapazes Barbapapazes deleted the feat/new-theme branch December 29, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants